Gerrit v3.4.0-rc3: weekly update

Merged Changes

From David Ostrovsky:

    Bazel: Remove assets parameter in polygerrit_plugin rule
    Change-Id: I86b996a4e98c7ea8ea35bfda097ff60092078028

    EventGsonProvider: Register generic event serializer adapter
    Change-Id: I7dc6e6a859152ee3e30a90075ddd34814720eba1

    EventJsonTest: Add test for custom event serialization
    Change-Id: I7e45f77aa980c03896e3891c2d48680e31d2e0a6

    Disable peer IP in reflog record per default
    Bug: Issue 10810
    Change-Id: Ia7a04cdce0425989059b92131afd8c2f6030d10b

    Allow to suppress peer IP in reflog records
    Bug: Issue 10810
    Change-Id: I5645a4e68fb48ad155609573aea2518480074697

    Remove enableReverseDnsLookup configuration option
    Change-Id: If33c6e1901b70ca64d9b32b0ebb310f3a9daf017

    Revert "Respect enableReverseDnsLookup option in ErrorLogJsonLayout"
    Change-Id: I8f74ca039246753f775b7bfc96596e3f5159af01

    Clean up polygerrit_plugin rule
    Change-Id: Ie46a8f02a2b485a856916fe14002dc6d0e710c20

From Paladox:

    Remove KnownExperimentId from gr-comment-thread
    Change-Id: Ib13d07e6dc71e3133fdc249c72809082c0fa915b

    Cleanup undefined check for access in getRepoAccess
    Change-Id: Ieefab7e709a4124409ced7cb86ecdde37748d906

From Frank Borden:

    Upgrade package.json dependencies
    Change-Id: Ifb400606b6c420f732bb36e87bf43018253757ee

From Ben Rohlfs:

    Add a SHOW ALL button to check result sections    
    Change-Id: I6be8585c285db6255e25060f61008cb57232f154

    Add support for top-level links in the Checks Tab
    Change-Id: Icca6e93b44b28d33607032e2a4d74327a684c2a8

    Remove experiments for comment context and checks
    Change-Id: I130b7846414e281062906def588151da71d72d96

    Implement a detailed check run hovercard
    Screenshot https://imgur.com/a/9grF5sm
    Change-Id: I185264d0ce02726487facda19c116b9351fc9a7f

    Fix target area for expanding/collapsing check result rows
    Change-Id: Ibdd08e8732e047c62a453b02324408466817305a

    Fix counting of selected and filtered check results
    Change-Id: Iea4c1816dd23272678bcd5aa0f3ff549257606ed

    Do not always show the checks error message
    Change-Id: I61656729770322bb1795c44fd297fda4d1a0256d

    Refined UI for checks error responses
    https://imgur.com/a/baILcJl
    Change-Id: I63f1cc5f128681f46cae3ab875744946b8537ea4

    Add handling of not-logged-in and error states
    Change-Id: I701a2fbdebca8d5b4adc437554b49597c8cc166a

    Fix checks utility for link icons
    https://imgur.com/a/ZMFEuGr
    Change-Id: Ie242e578ff91def52c559a10124d82b836077b90

    Change check tag/label font color from deemphasized to primary
    Change-Id: Ie2de29d019d7ccab8075d212600a3da0267fc8e1

    Add actions and links to check result rows    
    Change-Id: I2ff5a594bcc927910855d89c52484a5aef4581e0

    Fix the color of the attention and status icons
    Change-Id: I2a32e1f22848e122c0fd3016d8b91fbc16d029a6

    Only render expanded checks row once the user has clicked the row
    Change-Id: I4039953a63a84995577f309dcb2fbfee5680be86

From Milutin Kristofic:

    Remove new-change-summary feature flag from gr-change-view
    Change-Id: I971bc62bacc61b1985adb5de8d4fd36da68f2f46

    Remove old implementation of gr-related-changes-list
    Change-Id: Ic42f9af760042cd0e080a29b09c3d21d20bd161c

    Move tests from old to new gr-related-changes-list
    Change-Id: I631cde95d00a1e54b1820232733424b28f74bff4

    Remove new-change-summary feature flag from gr-change-summary
    Change-Id: Id27fb05cd42186cea5de068da791a73c7f0064cb

    Remove new-change-summary feature flag from gr-change-metadata    
    Change-Id: Ie2116e83e258b46c546056b6a9b6867e1dadcd35

    Remove new-change-summary feature flag from gr-thread-list   
    Change-Id: I8eaf790199c80956cf3c32e70d7e6fde133cabbd

    Remove new-change-summary feature flag from gr-thread-list    
    Change-Id: I8eaf790199c80956cf3c32e70d7e6fde133cabbd

    Remove new-change-summary feature flag from gr-editable-content    
    Change-Id: Ic324b6f210fc37ee5e52253dc0658c89e395c0ef

    Remove new-change-summary feature flag from gr-reviewer-list
    Change-Id: I6675f9e57244fd70b940d6a659e0dcd8d1533388

    Remove 'shared-styles' from most frequent gr-elements
    Change-Id: I7ab764397fb0bda92e7c784e5c0aac2d17c2e63d

    Remove new-change-summary feature flag from gr-change-requirements
    Change-Id: I77e6f174a73979b8c6e52f67953909e97964ae9e

    New change summary UI - fix small A11y issues
    Change-Id: I29310115583b7c5ac349923d6014dd49f66aaa1a

    Always show add topic row in metadata
    Change-Id: I794c028c8f9c81b43918511fac193b702c20f147

    Pressing enter on focused button supress keyboard shortcuts
    Change-Id: I6d28ebd022041a617be645fcd7f89ecb68d9cc54

From Dhruv Srivastava:

    Only show Merged As info if change has been merged
    Change-Id: I2405bf98dbb6542cb36cc0767dc79d61061bf3c8

    Remove patchset level comments from patchset dropdown count
    Change-Id: Ib4fc43e0c3797834b72a765ae2afce6f70871e9d

    Show user first in list of reviewers in change view
    Screenshot: https://imgur.com/a/FW60KC2
    Issue: Bug 14366
    Change-Id: I5ae9fc2e1b90f2dbbb7040d81be0e69f44ce9e3a

    Clean up Add Patchset Description from File List header
    Change-Id: Ia1ce16f776f81f734c0b03acce60a02e46190465

    Move Merged as info from change header to change summary
    Screenshot: https://imgur.com/a/MgZNe7G
    Change-Id: Ie2a5715dc65a20447f296f5246962b6445836490

    Show Code Review quick approve button with missing labels
    Change-Id: I3f9179177d92a7b7932353da1a36c5decad599ec
    (cherry picked from commit 25ca8ea4e9b9abb65ec6cc05af767a7e03b479da)

From Dmitrii Filippov:
    Fixes for Typescript 4.2
    Change-Id: I2387d5664c6748a1194ca52a0560d1d961ca64e4

    Fix and update license generator
    Bug: Issue 14175
    Change-Id: Ifd38a8e3ae7f06354e00aee420f282773b64583a

From Edwin Kempin:

    Export PluginPushOption for use in plugins
    Bug: Issue 14362
    Change-Id: Ie64c22bc4fed65950844dd4cd9a3e5328fe4eb8f

From Matthias Sohn:

    Welcome administrator of freshly installed Gerrit site
    Bug: Issue 12209
    Change-Id: Ib26372a610ab2e9c8266a71c9b2c41cfda9a051a

From Luca Milanesio:

    Avoid NPE when logging incoming HTTP request
    Bug: Issue 14410
    Change-Id: I4bdbe7418ccc4b223fa57b7fb49c2aa46f5d3982

    Add initial stream-events acceptance tests
    Bug: Issue 13799
    Change-Id: I6987d413ba911039e56950425b501573b4555204

Issues Fixed

  • Issue 10810 : Gerrit leaks user IP address to project owners
  • Issue 12209: Remind users that install Gerrit newly to join the Gerrit community and register on repo-discuss
  • Issue 13799: No tests for stream-events
  • Issue 14175: //Documentation:check_licenses target fails with python 3 on stable-3.3 branch
  • Issue 14362: uploadvalidator check should be bypassable
  • Issue 14410: NPE when tracking Gerrit HTTP logs
  • Issue 14366: Always show self first in list of reviewers on change page

Issues Raised

  • Issue 14336: PolyGerrit: no way to configure checkers using UI provided by checks plugin

Gatling E2E tests results

Git Protocol Simulation:

Gatling full results:
https://gerrit-ci.gerritforge.com/job/gatling-gerrit-test/315/gatling/report/gerritgitsimulation-20210426212117440/source/index.html

Gatling simulation class:
https://github.com/GerritForge/gatling-sbt-gerrit-test/blob/master/src/test/scala/gerritforge/GerritGitSimulation.scala

Gerrit UI REST Simulation:

Gatling full results:
https://gerrit-ci.gerritforge.com/job/gatling-gerrit-test/315/gatling/report/gerritrestsimulation-20210426212355447/source/index.html

Gatling simulation class:
https://github.com/GerritForge/gatling-sbt-gerrit-test/blob/master/src/test/scala/gerritforge/GerritRestSimulation.scala

Gatling 10-days trend

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out /  Change )

Google photo

You are commenting using your Google account. Log Out /  Change )

Twitter picture

You are commenting using your Twitter account. Log Out /  Change )

Facebook photo

You are commenting using your Facebook account. Log Out /  Change )

Connecting to %s