Merged Changes

From Luca Milanesio:

    Allow GerritAccount Cookie authentication for Git/HTTP
    Bug: Issue 14508
    Change-Id: I2a56197ee0dad479f0973192157e5970d9deac25

    Avoid multiple auth requests for Git/HTTP access
    Bug: Issue 14497
    Change-Id: Ibe41df0357b6be10bcdf0bd1f5a1b6160c34d4a4

    Introduce LDAP metrics
    Bug: Issue 14490
    Change-Id: I18e5d5b797b272ca11a6745bc39dcd73cab68c34

    Add unit-tests for ProjectBasicAuthFilter
    Change-Id: Ib9abf133d2128b6a29751ecbeda26b0b43115bb3

From Han-Wen Nienhuys:

    Documentation/user-review-ui: remove intraline diff mention
    Change-Id: I15faa971d5cfe80ab82295f1af4e307da1d17f10

    Documentation/user-review-ui: show just a single shortcut help screenshot
    Change-Id: I2ad396a20767221f293d2ec59e6ac61a85e12629

    Documentation/user-review-ui: remove mention of old UI
    Change-Id: I88adb24c5883410bc62b9e290e4077e6b845474a

    Documentation: rename all images for user-review.txt to gwt-*.png
    Change-Id: I42735800679736ef277a053e042908677c4db5ef

    Documentation: remove unused GWT image files
    Change-Id: Ie470c983509310b4a6eb35eedbc03ffa5e8028cd

From Matthias Sohn:

    Update jgit to a9579ba60cd2fd72179dfd8c2c37d389db5ec402
    [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=552173
    [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=573328
    Change-Id: Id3a4adc0faf27e7bcd2017ab439aa2230cf92b33

    Add new command convert-ref-storage to index
    Change-Id: If3a93e65333d1a5f299273711162d81e1b653e1b

From Antoine Musso:

    download_file: download to GERRIT_CACHE_HOME when set
    Change-Id: Ie4fac83928527e0e71b159b9500983234c2261ac

From Prudhvi Akhil Alahari:

    Fix EqualsLabelPredicate to not fail when calling match() from a plugin
    Change-Id: Icd2541fe26c18a8e61ce855862e0c9814a91f5ef

From Thomas Dräbing:

    Respect auth.userNameToLowerCase when creating accounts via REST or SSH
    Bug: Issue 14246
    Change-Id: If0f120f188e9f5bdf8008c4e66a55568180e7351

Issues Fixed

• Issue 14246: Creation of internal account does not respect auth.userNameToLowerCase
• Issue 14490: Missing LDAP metrics for authentication
• Issue 14497: Git/HTTP traffic overloads LDAP with duplicate authentication requests
• Issue 14508: Issue 14508: Gerrit authenticates more than once for a Git/HTTP high-level operation

Issues Raised

• Issue 14388: Mobile diff context buttons do not work properly

Gatling E2E results

Git protocol simulation:

Gatling full results:
https://gerrit-ci.gerritforge.com/job/gatling-gerrit-test/360/gatling/report/gerritgitsimulation-20210511183716601/source/index.html

Gatling simulation class:
https://github.com/GerritForge/gatling-sbt-gerrit-test/blob/master/src/test/scala/gerritforge/GerritGitSimulation.scala

Gerrit UI REST simulation:

Gatling full results:
https://gerrit-ci.gerritforge.com/job/gatling-gerrit-test/360/gatling/report/gerritrestsimulation-20210511184140917/source/index.html

Gatling simulation class:
https://github.com/GerritForge/gatling-sbt-gerrit-test/blob/master/src/test/scala/gerritforge/GerritRestSimulation.scala

Gatling 10-days trend

Merged Changes

From David Ostrovsky:

    Tidy up dev-plugins.txt documentation
    Change-Id: Ia3b09d5febcfe9ab1805bd2e55963aa6c6624f6a

    Reftable: Add convert-ref-storage ssh command
    Bug: Issue 14138
    Change-Id: I0ddd2370619de287ec757597ba57e8b757611808

    Bazel: Tidy up gerrit_js_bundle rule
    Change-Id: I9b3e757717a64e8538d5d05bdb86b3b26c9f363d

    Make srcs in gerrit_js_bundle optional
    Change-Id: Ifaca618836098798dfbad10c2f5c2aee10f6097f

    Fix link for change.enableAssignee configuration option
    Change-Id: I2faef25ea62119184e1a837b647b9cccdc246354

    ErrorJsonLogEntry: Use IP address as host value in logging event
    Change-Id: Ie3a246ff277a0b8646dbe11acdb2b53aa659800e

    Bazel: Add gerrit_js_bundle rule
    Change-Id: Ia8421a9ef6f1ad91808bb698769da84022f63973

From Edwin Kempin:

    Allow tests to check how much Counter0 metrics are increased by a call
    Change-Id: I79da799c86325eb64922a92caec8a476e4e6a4ae

From Ben Rohlfs:

    Improved and more sophisticated handling of check action results
    Change-Id: I4f139bbe913c60fbdcea27dd9ea1e3f605bb19cb

    Add documentation for the new Checks JavaScript Plugin API
    Change-Id: I82cd3c9af9c918b1c26ea1cb8a70e3283138ac31

    Add links to frontend plugin examples
    Bug: Issue 14421
    Change-Id: I123f1717ac691eda20709c20764db457c58b42e2

    Remove draft warning from Checks API
    Change-Id: I267b2792efee3baa27ebbe6915b0c7813efab566

    Update all the plugin examples
    Change-Id: Idc6473377bb5966f0bc199bfc68977297df4f802

    Tiny documentation fix
    Change-Id: I505419cdf03bfe5dd3a1dd28eeb84def36a3669a

    Update the JavaScript Plugin API documentation
    Bug: Issue 14421
    Change-Id: I5869c8168fe27bea81226b0b8f1dc40b271c2454

From Youssef Elghareeb:

    Rename SubmitRequirement to LegacySubmitRequirement
    Change-Id: Ib55038627c95ece82a7eddd64e317183f1752487

From Patrick Hiesel:

    SubmitRecord.Status: Reserve RULE_ERROR for user-caused errors
    Change-Id: I018ce9e13fa40f2f24546df49ecf7fc3fbb72b1b

Issues Fixed

• Issue 14138: expose JGit reftable conversion as Gerrit SSH command
• Issue 14421: Update the Frontend Plugin Documentation

Issues Raised

None

Gatling E2E results

Git protocol simulation:

Gatling full results:
https://gerrit-ci.gerritforge.com/job/gatling-gerrit-test/348/gatling/report/gerritgitsimulation-20210504002334245/source/index.html

Gatling simulation class:
https://github.com/GerritForge/gatling-sbt-gerrit-test/blob/master/src/test/scala/gerritforge/GerritGitSimulation.scala

Gerrit UI REST simulation:

Gatling full results:
https://gerrit-ci.gerritforge.com/job/gatling-gerrit-test/315/gatling/report/gerritrestsimulation-20210426212355447/source/index.html

Gatling simulation class:
https://github.com/GerritForge/gatling-sbt-gerrit-test/blob/master/src/test/scala/gerritforge/GerritRestSimulation.scala

Gatling 10-days trend